Dave Jarvis' Repositories

git clone https://repo.autonoma.ca/repo/keenwrite.git

Off by 1 bug.

Authordjarvis <email>
Date2016-12-29 11:58:40 GMT-0800
Commit5aa256c4d0f16d2e87a4f9ff5cd943df376ef4e0
Parent120fee4
Delta12 lines added, 3 lines removed, 9-line increase
src/main/java/com/scrivenvar/editors/VariableNameInjector.java
private String extractTextChunk() {
final StyledTextArea textArea = getEditor();
- final int textBegan = getInitialCaretPosition();
- final int remaining = textArea.getLength() - textBegan;
- final int textEnded = min( remaining - 1, getMaxVarLength() );
+ int textBegan = getInitialCaretPosition();
+ final int length = textArea.getLength();
+ final int remaining = length - textBegan;
+ int textEnded = min( remaining, getMaxVarLength() );
+
+ if( textBegan < 0 ) {
+ textBegan = 0;
+ }
+
+ if( textEnded > length ) {
+ textEnded = length;
+ }
return textArea.getText( textBegan, textEnded );